Skip to content

docs: update README Firefox not found example #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2024
Merged

docs: update README Firefox not found example #1056

merged 1 commit into from
May 20, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

README > Firefox not found refers to outdated GitHub JavaScript action versions, which use the deprecated / end-of-life node16 version:

name: E2E in custom container
on: push
jobs:
  cypress-run:
    runs-on: ubuntu-22.04
    container:
     image: cypress/browsers:node18.12.0-chrome106-ff106
     options: --user 1001
    steps:
      - uses: actions/checkout@v3
      - uses: cypress-io/github-action@v5
        with:
          browser: firefox

Change

Update the example in README > Firefox not found to use latest and supported versions:

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

Sign in to view
@MikeMcC399 MikeMcC399 force-pushed the ff-not-found-example branch from 87efc0d to 89f6c46 Compare May 20, 2024 09:34
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 20, 2024 09:48
@jennifer-shehane jennifer-shehane merged commit 71659d3 into cypress-io:master May 20, 2024
31 checks passed
@MikeMcC399 MikeMcC399 deleted the ff-not-found-example branch May 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees

@MikeMcC399 MikeMcC399

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcC399 @cypress-app-bot @jennifer-shehane